popularity bands#138
Merged
Merged
Conversation
This was referenced May 15, 2021
Member
Author
|
opening for review, needs a quick look-over before merging, add comments about later opportunities for configuration. |
Member
Author
|
testing showed a significant improvement. we are open to extending/tuning this functionality and/or making it configurable via |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in pelias/openstreetmap#493 (comment), this draft PR ensures that documents on the
postalcodelayer receive a minimumpopularityvalue.I'm opening this up for testing now, I think (if it's successful) that we will probably want to make the
MIN_POPULARITY_MAPstructure configurable viapelias/config.note: I've selected an initial value of
9000for testing postalcodes, this is just a guess based on the values in https://github.com/pelias/openstreetmap/blob/master/stream/popularity_mapper.js and may need to be refined, pending testing.