popularity: do not penalize abandoned:amenity=place_of_worship#552
Conversation
|
Also worth noting that users who enable the config option |
|
I spent some more time looking at this and TBH it's really not clear how we (and other geocoders) should interpret The wiki says:
Although I disagree with the comment "The name is still relevant, and will still be searchable". I think the author of that comment is specifically referring to it still being returned by nominatim for mappers to find and edit. It's not clear if Pelias is a "program which locates shops" or a program which makes things "searchable" in that context. A large number of places tagged However, in OSM there's an exception to every rule, there seem to be some places tagged |
|
As this change only currently affects 421 records I'm happy to merge it as-is. |
As per pelias/geonames#394 this PR is to fix the scoring of the query for "Angkor Wat".
Pelias is currently giving the OSM record a negative popularity as it's tagged
abandoned:amenity=place_of_worship.We originally assumed that
abandoned:amenitymeant it was no longer important but that doesn't seem to be the case, either it's mis-tagged or we're interpreting the tag wrong. The OSM wiki seems to confirm our view, but who knows 🤷♂️ .This PR maintains the negative scoring for all
abandonedandabandoned:*tags with a single exception forabandoned:amenity=place_of_worship.Currently that only affects 421 records so it's unlikely to have any negative side-effects.