PMM-15031: Point PMM emails at the new logo URL - #921
Open
mattiasimonato wants to merge 3 commits into
Open
Conversation
emails/package.json pins mjml at ^4.13.0 with no lockfile, so a fresh install now resolves 4.18, where mj-body emits role, aria-roledescription and aria-label. Upstream already ships that markup in public/emails/verify_email.html, so regenerating only brings the other templates in line with it. The @percona markers have to leave mj-title for that. mjml copies the title content into aria-label, so with the comment inside the marker landed in the generated HTML as aria-label="{{ __dangerouslyInjectHTML `<!-- @percona -->` }} ...". Moving them one line up keeps both the marker and the attribute clean. The rendered subject does not change: subjectTemplateFunc caches its result, so the extra call from aria-label is a no-op.
The percona.com product-logo URL the header used disappeared with the rebranding, so every PMM email rendered a broken image. The logo now ships with the PMM docs site, a public host we control, and its source of truth is documentation/docs/assets/pmm-logo-email.png in percona/pmm. The asset is 432x193 and is rendered at 216px so it stays sharp on 2x displays.
This was referenced Aug 24, 2026
matejkubinec
approved these changes
Aug 25, 2026
fabio-silva
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket number: PMM-15031
Feature build: SUBMODULES-4543
PMM emails showed a broken logo. The header pointed at a percona.com product-logo URL that was deleted during the rebranding. The logo now lives on the PMM docs site, which is a public host we control, so the email header points there instead.
The PR has two commits. The first is mechanical:
emails/package.jsonpins mjml at^4.13.0with no lockfile, so rebuilding the templates today uses 4.18, which addsrole,aria-roledescriptionandaria-labelto the wrapper div. Upstream already ships that markup inpublic/emails/verify_email.html, so this only brings the other templates in line. It also moves the<!-- @PERCONA -->markers out of<mj-title>, because mjml copies the title intoaria-labeland the comment ended up inside that attribute. The second commit is the real fix: the new logo URL inemails/templates/partials/layout/header.mjml, plus the regenerated HTML.The asset itself is added by percona/pmm#5829, which must merge first, so the URL already works when these templates start using it.