Skip to content
This repository was archived by the owner on Aug 24, 2022. It is now read-only.

PMM-9632 Settings view usage. #374

Open
JiriCtvrtka wants to merge 17 commits into
base: main
Choose a base branch
from
Open

PMM-9632 Settings view usage. #374

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
e1226b1
PMM-9632 Struct draft.
May 3, 2022
564c1c7
PMM-9632 Changes.
May 4, 2022
630d0dd
PMM-9632 Changes in models, methods, etc.
May 4, 2022
5b380a1
PMM-9632 Pointers to possible nil values.
May 4, 2022
a764a32
PMM-9632 Gen.
May 4, 2022
3f7f08e
PMM-9632 Changes.
May 5, 2022
faec4ce
Merge branch 'main' into PMM-9632-settings-view
May 6, 2022
cc7b296
PMM-9632 Another changes.
May 6, 2022
ed93bb9
PMM-9632 Lint.
May 6, 2022
274fbb4
Merge branch 'main' into PMM-9632-settings-view
JiriCtvrtka May 10, 2022
8054441
PMM-9632 Lint.
May 10, 2022
d524caa
PMM-9632 Revert settings into QAN feature.
May 13, 2022
ecc37e7
PMM-9632 Required changes.
May 15, 2022
6bac794
PMM-9632 Remove empty line.
May 15, 2022
3e8c192
PMM-9632 Fix tests.
May 15, 2022
86d99a2
PMM-9632 Fix bug for older versions.
May 16, 2022
4912906
Merge branch 'main' into PMM-9632-settings-view
JiriCtvrtka May 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions agents/postgres/pgstatmonitor/models.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,14 @@ type pgStatMonitorSettings struct {
//
//reform:pg_stat_monitor_settings
type pgStatMonitorSettingsTextValue struct {
Name string `reform:"name"`
Value string `reform:"value"`
Name string `reform:"name"`
Value string `reform:"value"`
DefaultValue string `reform:"default_value"`
Description string `reform:"description"`
Minimum *int64 `reform:"minimum"`
Maximum *int64 `reform:"maximum"`
Options *string `reform:"options"`
Restart string `reform:"restart"`

@BupycHuk BupycHuk May 13, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's keep only fields that we use in case PGSM team changes structure later we will have more PMM clients supported latest PGSM

@JiriCtvrtka JiriCtvrtka May 15, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

}

// pgStatMonitorExtended contains pgStatMonitor data and extends it with database, username and tables data.
Expand Down
32 changes: 31 additions & 1 deletion agents/postgres/pgstatmonitor/models_reform.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading