Add QAN URL state persistence tests

[kiranvuyurru]

Add comprehensive tests for URL state persistence across RTA overview, sessions, and stored metrics pages. Includes new page object methods and locators for filters, pagination, and rows-per-page controls. Adds mock helper for RTA sessions and new storedMetrics URL state test suite (PMM-T2265, PMM-T2266, PMM-T2267, PMM-T2268).
https://github.com/percona/pmm-qa/actions/runs/31022412293/job/92362695351

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 9794f3bf-9371-4dbf-a83d-ad78f11aa513

📥 Commits

Reviewing files that changed from the base of the PR and between 0d3c0fb and 1f97c18.

📒 Files selected for processing (2)

• e2e_tests/pages/qan/rta/realTimeAnalytics.page.ts
• e2e_tests/tests/qan/storedMetrics/urlState.test.ts

🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

• percona/pmm-qa (manual)
• percona/pmm (manual)

🚧 Files skipped from review as they are similar to previous changes (2)

• e2e_tests/pages/qan/rta/realTimeAnalytics.page.ts
• e2e_tests/tests/qan/storedMetrics/urlState.test.ts

---

Walkthrough

Changes

URL State Coverage

Layer / File(s)	Summary
RTA overview state e2e_tests/pages/qan/rta/realTimeAnalytics.page.ts, e2e_tests/tests/qan/rta/overview.test.ts	RTA coverage verifies URL persistence and reload restoration for query filters, page size, elapsed-time sorting, service IDs, and decimal duration filters.
RTA sessions pagination e2e_tests/helpers/apiEndpoints.ts, e2e_tests/helpers/mocks.helper.ts, e2e_tests/pages/qan/rta/realTimeAnalytics.page.ts, e2e_tests/tests/qan/rta/session.test.ts	The sessions endpoint uses deterministic mock data. The test verifies session page-size persistence and row-count restoration after reload.
Stored Metrics URL state e2e_tests/pages/qan/storedMetrics/storedMetrics.page.ts, e2e_tests/tests/qan/storedMetrics/urlState.test.ts	Stored Metrics coverage verifies service-type filters, pagination, debounced search, shared URL navigation, restored state, and browser console errors.

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main change: adding QAN URL state persistence tests.
Description check	✅ Passed	The description directly explains the URL persistence tests, page object updates, mock helper, and covered test cases.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

---

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 4

🧹 Nitpick comments (1)

e2e_tests/tests/qan/storedMetrics/urlState.test.ts (1)

17-68: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Split the scenario into test.step() phases.

Separate filter changes, pagination changes, URL assertions, and shared-URL restoration into named steps. This makes a failed URL-state assertion identifiable in CI output.

As per coding guidelines, “Use Playwright's test.step() for readable test structure.”

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@e2e_tests/tests/qan/storedMetrics/urlState.test.ts` around lines 17 - 68,
Split the scenario in the test callback into named Playwright test.step phases
covering filter changes, pagination changes, URL assertions, and shared-URL
restoration. Move the corresponding existing actions and assertions into these
steps without changing their order or behavior, and keep console-error
collection and cleanup correctly scoped across the full scenario.

Source: Coding guidelines

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@e2e_tests/tests/qan/rta/overview.test.ts`:
- Around line 262-274: Select a known service in the test before capturing
serviceIds, using the existing service-selection control or helper. Assert that
the pre-reload URL contains the selected service ID, then preserve the existing
reload flow and verify the post-reload serviceIds matches the captured value.
- Around line 245-275: Add readable pmmTest.step() blocks to structure the
URL-state tests: in e2e_tests/tests/qan/rta/overview.test.ts lines 245-275,
separate state setup, URL verification, reload, and restored-state checks; in
lines 278-331, separate duration setup, filtered-results verification, URL
verification, and restoration checks; in e2e_tests/tests/qan/rta/session.test.ts
lines 55-72, separate mock setup, page-size selection, URL verification, and
reload checks.

In `@e2e_tests/tests/qan/storedMetrics/urlState.test.ts`:
- Line 16: Add the `@qan` tag to the test title for “PMM-T2268 Verify QAN shared
URL restores filters and pagination,” while retaining the existing `@rta` tag.
- Line 26: Wrap the test body after the page setup and console listener
registration in a try/finally block. Keep the existing assertions and test flow
in try, and move page.off('console', collectErrors) plus sharedPage.close() into
finally so both cleanup operations run on success and failure.

---

Nitpick comments:
In `@e2e_tests/tests/qan/storedMetrics/urlState.test.ts`:
- Around line 17-68: Split the scenario in the test callback into named
Playwright test.step phases covering filter changes, pagination changes, URL
assertions, and shared-URL restoration. Move the corresponding existing actions
and assertions into these steps without changing their order or behavior, and
keep console-error collection and cleanup correctly scoped across the full
scenario.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 31dd7321-b48b-4220-a07f-0ac1c7967a38

📥 Commits

Reviewing files that changed from the base of the PR and between 9cc19fb and b5934e1.

📒 Files selected for processing (7)

• e2e_tests/helpers/apiEndpoints.ts
• e2e_tests/helpers/mocks.helper.ts
• e2e_tests/pages/qan/rta/realTimeAnalytics.page.ts
• e2e_tests/pages/qan/storedMetrics/storedMetrics.page.ts
• e2e_tests/tests/qan/rta/overview.test.ts
• e2e_tests/tests/qan/rta/session.test.ts
• e2e_tests/tests/qan/storedMetrics/urlState.test.ts

🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

• percona/pmm-qa (manual)
• percona/pmm (manual)