PMM-15280 Expect 48 files in pmm-admin summary zip - #1167
Closed
claude[bot] wants to merge 1 commit into
Closed
Conversation
percona/pmm#5755 adds the sep-provision supervisord program, whose stdout_logfile /srv/logs/sep-provision.log is collected into the server logs.zip on every install, SEP enabled or not. The summary archive therefore holds one more file than the hard-coded 47. Blocked on percona/pmm#5755 -- expected red on main until it lands. Signed-off-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failures fixed (investigator)
CLI / Integration tests / CLI / Integration / Genericmainyet.cli/tests/generic.spec.ts:190/@generic— "run pmm-admin summary --server-url --server-insecure-tls with https"What failed
Note the FB job's own "Run CLI tests" step reported success — it ends in
|| true. The job went red one step later, at the Launchable gate (FAILED | Quarantined 0 | Actionable Failures 1).Root cause — a real, intended product addition the count didn't know about
percona/pmm#5755 adds a supervisord program
sep-provisionwithstdout_logfile = /srv/logs/sep-provision.log. PMM collects everything under/srv/logs/into the serverlogs.zip, so the summary archive gains one file.It is not conditional on SEP: the program is
autostart = trueand merelyexits early when
PMM_ENABLE_SEPis unset, so supervisord creates the log fileon every install. Confirmed on a stock FB server with no SEP env var set:
The PMM PR updated its own fixed expectation (
api-tests/server/logs_test.gogained
"sep-provision.log"); pmm-qa's hard-coded 47 is the copy nobody saw.Isolating the server side alone,
GET /logs.zipfrom each image:Why this is blocked
Reproduced and verified on a throwaway VM, same setup as the runner
(
--database pdpgsql=16 --database ps,ENCRYPTED_CLIENT_CONFIG=true):maintoday)perconalab/pmm-server-fb:PR-4500-38283f6(carries #5755)perconalab/pmm-server:3-dev-latest(main)So merging now turns the nightly/e2e
Genericjob red until #5755 lands.Ready to merge the moment it does — no rework expected, the count is already
the post-merge value.
The two other hard-coded counts in this file (
43, lines 338 and 385) are leftalone: both sit in
--pproftests that are unconditionallytest.skipped.Generated by Claude Code