Skip to content

PMM-15280 Expect 48 files in pmm-admin summary zip - #1167

Closed
claude[bot] wants to merge 1 commit into
mainfrom
claude/kind-meitner-hbiys8
Closed

PMM-15280 Expect 48 files in pmm-admin summary zip#1167
claude[bot] wants to merge 1 commit into
mainfrom
claude/kind-meitner-hbiys8

Conversation

@claude

@claude claude Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Failures fixed (investigator)

  • source: Percona-Lab/pmm-submodules#4500 — run 31568198713, check CLI / Integration tests / CLI / Integration / Generic
  • blocked-on: percona/pmm#5755 (PMM-15280) — DO NOT MERGE until that PR lands; this test now expects behavior that doesn't exist on main yet.
  • tests:
    • cli/tests/generic.spec.ts:190 / @generic — "run pmm-admin summary --server-url --server-insecure-tls with https"

What failed

Error: Verify there are 47 files in /tmp/summary_...zip
Expected length: 47
Received length: 48

Note the FB job's own "Run CLI tests" step reported success — it ends in || true. The job went red one step later, at the Launchable gate (FAILED | Quarantined 0 | Actionable Failures 1).

Root cause — a real, intended product addition the count didn't know about

percona/pmm#5755 adds a supervisord program sep-provision with
stdout_logfile = /srv/logs/sep-provision.log. PMM collects everything under
/srv/logs/ into the server logs.zip, so the summary archive gains one file.

It is not conditional on SEP: the program is autostart = true and merely
exits early when PMM_ENABLE_SEP is unset, so supervisord creates the log file
on every install. Confirmed on a stock FB server with no SEP env var set:

$ docker exec pmm-server ls /srv/logs/
... qan-api2.log  sep-provision.log  supervisord.log ...

The PMM PR updated its own fixed expectation (api-tests/server/logs_test.go
gained "sep-provision.log"); pmm-qa's hard-coded 47 is the copy nobody saw.

Isolating the server side alone, GET /logs.zip from each image:

only in FB  : ['sep-provision.log']
only in main: []

Why this is blocked

Reproduced and verified on a throwaway VM, same setup as the runner
(--database pdpgsql=16 --database ps,ENCRYPTED_CLIENT_CONFIG=true):

PMM Server image expects 47 (main today) expects 48 (this PR)
perconalab/pmm-server-fb:PR-4500-38283f6 (carries #5755) ✗ fails, got 48 passes
perconalab/pmm-server:3-dev-latest (main) ✓ passes ✗ fails, got 47

So merging now turns the nightly/e2e Generic job red until #5755 lands.
Ready to merge the moment it does — no rework expected, the count is already
the post-merge value.

The two other hard-coded counts in this file (43, lines 338 and 385) are left
alone: both sit in --pprof tests that are unconditionally test.skipped.


Generated by Claude Code

percona/pmm#5755 adds the sep-provision supervisord program, whose
stdout_logfile /srv/logs/sep-provision.log is collected into the server
logs.zip on every install, SEP enabled or not. The summary archive
therefore holds one more file than the hard-coded 47.

Blocked on percona/pmm#5755 -- expected red on main until it lands.

Signed-off-by: Claude <noreply@anthropic.com>
@travagliad travagliad closed this Aug 13, 2026
@travagliad
travagliad deleted the claude/kind-meitner-hbiys8 branch August 13, 2026 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants