PMM-15308 Expect trimmed dashboard panel titles - #1173
Closed
claude[bot] wants to merge 1 commit into
Closed
Conversation
percona/pmm#5767 trims leading/trailing whitespace from dashboard titles, which breaks three expected-panel lists that hard-coded the untrimmed strings: - MySQL Group Replication Summary: 'Applied Transactions ', 'Sent Transactions ', 'Rolled Back Transactions ' - HAProxy Instance Summary: 'Aborted Data Transfers ' - MySQL User Details: the spacer text panel titled ' ', now '', whose header no longer renders a title at all -- drop the entry instead of asserting an empty name. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YGvF1XjQP42JbzU555BuRP Signed-off-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failures fixed (investigator)
E2E / Percona Server for MySQL UI integration tests / e2e tests: @pmm-ps-integrationmainyet.e2e_tests/tests/dashboards/mysql/mysqlDashboards.test.ts:77— PMM-T324 Verify MySQL - MySQL User Details dashboard /@pmm-ps-integratione2e_tests/tests/dashboards/mysql/mysqlDashboards.test.ts:130— PMM-T430 Verify metrics on MySQL Group Replication Summary Dashboard /@pmm-ps-integrationWhat failed
Both tests failed in
Dashboards.verifyMetricsPresent(pages/dashboards/dashboards.page.ts:160) — the panel titles rendered by the FB server no longer match the expected lists:Root cause — the FB trims whitespace from dashboard titles
PR #4525 is the feature build for percona/pmm#5767 (PMM-15308), which strips leading/trailing whitespace from 39 dashboard titles. Three of the trimmed titles were hard-coded with their whitespace in pmm-qa's expected-panel lists:
main"Applied Transactions ""Applied Transactions""Sent Transactions ""Sent Transactions""Rolled Back Transactions ""Rolled Back Transactions"" "(spacertextpanel)"""Aborted Data Transfers ""Aborted Data Transfers"Read back from the running FB server (
/graph/api/dashboards/uid/mysql-group-replicaset-summary,…/uid/mysql-user), the titles are trimmed exactly as the diff says.For MySQL User Details the panel is a title-less spacer: with
title: ""Grafana renders no title text at all, so the panel contributes nothing toallTextContents()— asserting''would be meaningless, so the entry is dropped rather than emptied.Aborted Data Transfersis the same class of stale expectation but under@pmm-ps-pxc-haproxy-integration, which the FB suite doesn't run — it runs in the dailye2e-tests-matrix.yml, so without this it would go red the day #5767 merges. Fixed here in the same commit.Verification
Throwaway Linode VM, PMM Server
perconalab/pmm-server-fb:PR-4525-94197ef(the exact image the failing run used), client tarballpmm-client-PR-4525-94197ef.tar.gz,pmm-framework --database ps,SETUP_TYPE=replication,MY_ROCKS=true --database ps,SETUP_TYPE=gr,QUERY_SOURCE=slowlog— sameWIZARD_ARGSas the failing job.main@pmm-ps-integrationPMM-T2030 - Verify QAN for PS Replica Instancefailed on the repro VM on bothmainand this branch (QAN showed no data — the replication setup on this box never generated replica query load), and passed in the CI run. Environmental, not related to this change, which only edits three panel-name lists.@pmm-ps-pxc-haproxy-integrationwas not exercised (no HAProxy/PXC setup on the repro box); the HAProxy line is verified against the FB dashboard JSON only, so the nexte2e-tests-matrix.ymlrun after #5767 merges is what confirms it end to end.Pre-existing, untouched:
npx tsc --noEmitreports the same 4 errors intests/dashboards/valkey/valkeyDashboards.test.tsbefore and after this change. ESLint is clean on the three edited files.Other red in that FB run (triaged, not fixed here)
@pmm-psmdb-arbiter-integrationandCLI / Integration / PSMDB Shard 8.x— both died in setup withexec: "mgodatagen": executable file not found in $PATHafter a transientcurl: (22) … 503while building the psmdb image. Already covered by open PRs Fail the PSMDB image build when mgodatagen install fails #1172 / Fail the psmdb-pbm image build when a download fails #1171.Helm testsand@pmm-psmdb-replica-integration— failed in the triggering run, passed in the re-dispatched run on the same commit. Flaky.Follow-up
Convert from draft to ready once percona/pmm#5767 merges.
The legacy CodeceptJS
osNodesOverview.metricslist (codeceptjs-e2e/tests/pages/dashboardPage.js) also carries untrimmed Nodes Overview titles, but nothing asserts that list (onlyclearUrlis used), so it is left alone.Generated by Claude Code