Skip to content

Override PMM-T526's health start-period so the unhealthy verdict lands #1181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
claude wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −3
Open

Override PMM-T526's health start-period so the unhealthy verdict lands #1181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions cli/tests/pmm-server-only.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,11 @@ test.describe(
test('PMM-T526 Use Invalid Prometheus Custom Config File to Check if Container is unhealthy', async ({}) => {
const containerName = 'PMM-T526';
const httpPort = 84;
// The image ships a 720s health start-period to cover SEP provisioning's Grafana wait, and
// Docker withholds the unhealthy verdict for the whole of it. Override only that field, so the
// image's own healthcheck command still decides but its verdict lands in seconds.
await cli.exec(
`docker run -d -p ${httpPort}:8080 -p 449:8443 --name ${containerName} ${DOCKER_IMAGE}`,
`docker run -d -p ${httpPort}:8080 -p 449:8443 --health-start-period=25s --name ${containerName} ${DOCKER_IMAGE}`,
);
stopList.push(containerName);
removeList.push(containerName);
Expand All @@ -133,12 +136,12 @@ test.describe(
).assertSuccess();
await cli.exec(`docker restart ${containerName}`);

await test.step(`Waiting for ${containerName} to be unhealthy(45 sec)`, async () => {
await test.step(`Waiting for ${containerName} to be unhealthy(90 sec)`, async () => {
await expect(async () => {
await (
await cli.exec(`docker ps | grep ${containerName}`)
).outContains('unhealthy');
}).toPass({ intervals: [2_000], timeout: 45_000 });
}).toPass({ intervals: [2_000], timeout: 90_000 });
});
});

Expand Down
Loading