Skip to content

Read PMM-T269's selected filter through Show selected #1186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
claude wants to merge 1 commit into from
+10 −2
Closed

Read PMM-T269's selected filter through Show selected #1186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion codeceptjs-e2e/tests/QAN/common_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,10 @@ Scenario('PMM-T269 - Verify QAN UI Elements are displayed @qan', async ({ I, que

await queryAnalyticsPage.filters.selectFilterInGroupAtPosition(filter, randomFilterValue);
I.assertTrue((await queryAnalyticsPage.data.getRowCount()) > 0, `No values for filter: "${filter}" were displayed`);
await queryAnalyticsPage.filters.selectFilterInGroupAtPosition(filter, randomFilterValue);
// Selecting re-sorts the group, so clicking the same position again would
// toggle a different value and leave this group's filter applied.
queryAnalyticsPage.filters.resetAllFilters();
queryAnalyticsPage.waitForLoaded();
}

const serverNodeName = homePage.pmmServerName;
Expand All @@ -49,6 +52,9 @@ Scenario('PMM-T269 - Verify QAN UI Elements are displayed @qan', async ({ I, que

queryAnalyticsPage.filters.selectContainFilterInGroup(serviceFilter, 'Service Name');
I.wait(3);
// The filter groups are virtualised, so a selected value that sits below the
// group's viewport is not rendered at all -- "Show selected" brings it back.
queryAnalyticsPage.filters.showSelectedFilters();
const displayedServiceName = await I.grabTextFrom(queryAnalyticsPage.filters.fields.checkedFilters());

I.assertContain(
Expand Down
4 changes: 3 additions & 1 deletion codeceptjs-e2e/tests/pages/components/queryAnalytics/queryAnalyticsFilters.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,9 @@ class QueryAnalyticsFilters {
filterLinkByNameAndGroup: (filterName, groupName) => this.fields.filterByNameAndGroup(filterName, groupName).find('a'),
filterPercentageByNameAndGroup: (filterName, groupName) => this.fields.filterByNameAndGroup(filterName, groupName).find('//span').at(3),
filterName: locate('//span[@class="checkbox-container__label-text"]'),
checkedFilters: () => this.fields.filterCheckboxes.find('//input[@type="checkbox" and @checked]//following-sibling::span[@class="checkbox-container__label-text"]'),
// ':checked' reads the live property; the 'checked' attribute React
// writes only reflects the state the input was mounted with.
checkedFilters: () => locate('div[data-testid*="filter-checkbox"] input[type="checkbox"]:checked ~ span.checkbox-container__label-text'),
groupElementsCount: (groupName) => `//span[contains(text(), '${groupName}')]/following-sibling::span[contains(text(), 'Show all')]`,
};
this.buttons = {
Expand Down
Loading