Stop QAN copy-link and PBM panel checks racing late data - #1202
Stop QAN copy-link and PBM panel checks racing late data#1202travagliad wants to merge 4 commits into
Conversation
PMM-T1142 copies a link built from the suite's now-5m window, whose last minutes are still being aggregated. Re-querying that same absolute range 90s later on a repro VM returned 400 -> 413 groups in a different load order; in nightly run 32200025112 it went 433 -> 436 and the selected query left page 2 entirely, so .selected-overview-row never appeared. Anchor the scenario on now-15m..now-5m, a closed window that returns identical rows on every fetch. PMM-T2036 (PITR) failed on an empty Backup Sizes panel. The run's Playwright trace shows why: Last Successful Backup was re-queried 16 times by waitForLastSuccessfulBackupValue (15 empty, then data), while Backup Sizes was queried exactly once -- empty, before PBM published a status=done sample -- and never again, because that poll keeps the viewport at the top of the dashboard and Grafana only re-runs a panel's query while it is on screen. Add waitForLateMetricPanels to poll the bottom panels with each one in view, so the empty-panel check reads current state rather than a stale render. Signed-off-by: travagliad <215686151+travagliad@users.noreply.github.com>
A 10-minute window can be sparse when a suite reaches this scenario shortly after the clients register. Starting the window earlier can only add rows, so page 2 stays reachable while the window is still closed. Signed-off-by: travagliad <215686151+travagliad@users.noreply.github.com>
|
Warning Review limit reached
Next review available in: 57 minutes Limit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. WalkthroughThe PMM-T1142 QAN test now loads the closed ChangesE2E test stability
Possibly related PRs
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-authored-by: travagliad <215686151+travagliad@users.noreply.github.com>
1 participant
This PR refreshes QAN page with -30m to -5m so we have a bigger window of queries selected and keep having page 2, as on latest nightly run it failed for not having a page 2 by the time the test was executed (-5m to now)