Skip to content

Fix connection pool leak in RunChecks when table validation fails #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mason-sharp merged 2 commits into from
Apr 10, 2026
Merged

Fix connection pool leak in RunChecks when table validation fails #105

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
55fdce4
Fix connection pool leak in RunChecks when table validation fails
mason-sharp Apr 10, 2026
09650f8
Assert RunChecks failure path is exercised in leak accumulation test
mason-sharp Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
102 changes: 53 additions & 49 deletions internal/consistency/diff/table_diff.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -877,68 +877,72 @@ func (t *TableDiffTask) RunChecks(skipValidation bool) (err error) {
continue
}

conn, err := auth.GetClusterNodeConnection(t.Ctx, nodeInfo, t.connOpts())
if err != nil {
return fmt.Errorf("failed to connect to node %s: %w", hostname, err)
}
if err := func() error {
conn, err := auth.GetClusterNodeConnection(t.Ctx, nodeInfo, t.connOpts())
if err != nil {
return fmt.Errorf("failed to connect to node %s: %w", hostname, err)
}
defer conn.Close()

currCols, err := queries.GetColumns(t.Ctx, conn, schema, table)
if err != nil {
return fmt.Errorf("failed to get columns for table %s.%s on node %s: %w", schema, table, hostname, err)
}
if len(currCols) == 0 {
return fmt.Errorf("table '%s.%s' not found on %s, or the current user does not have adequate privileges", schema, table, hostname)
}
currCols, err := queries.GetColumns(t.Ctx, conn, schema, table)
if err != nil {
return fmt.Errorf("failed to get columns for table %s.%s on node %s: %w", schema, table, hostname, err)
}
if len(currCols) == 0 {
return fmt.Errorf("table '%s.%s' not found on %s, or the current user does not have adequate privileges", schema, table, hostname)
}

currKey, err := queries.GetPrimaryKey(t.Ctx, conn, schema, table)
if err != nil {
return fmt.Errorf("failed to get primary key for table %s.%s on node %s: %w", schema, table, hostname, err)
}
if len(currKey) == 0 {
return fmt.Errorf("no primary key found for '%s.%s'", schema, table)
}
currKey, err := queries.GetPrimaryKey(t.Ctx, conn, schema, table)
if err != nil {
return fmt.Errorf("failed to get primary key for table %s.%s on node %s: %w", schema, table, hostname, err)
}
if len(currKey) == 0 {
return fmt.Errorf("no primary key found for '%s.%s'", schema, table)
}

if len(cols) == 0 && len(key) == 0 {
cols = currCols
key = currKey
}
if len(cols) == 0 && len(key) == 0 {
cols = currCols
key = currKey
}

if !reflect.DeepEqual(currCols, cols) || !reflect.DeepEqual(currKey, key) {
return fmt.Errorf("table schemas don't match between nodes")
}
if !reflect.DeepEqual(currCols, cols) || !reflect.DeepEqual(currKey, key) {
return fmt.Errorf("table schemas don't match between nodes")
}

cols = currCols
key = currKey
cols = currCols
key = currKey

colTypes, err := queries.GetColumnTypes(t.Ctx, conn, schema, table)
if err != nil {
return fmt.Errorf("failed to get column types for table %s on node %s: %w", table, hostname, err)
}
colTypes, err := queries.GetColumnTypes(t.Ctx, conn, schema, table)
if err != nil {
return fmt.Errorf("failed to get column types for table %s on node %s: %w", table, hostname, err)
}

colTypesKey := fmt.Sprintf("%s:%s", hostIP, port)
colTypesKey := fmt.Sprintf("%s:%s", hostIP, port)

if t.ColTypes == nil {
t.ColTypes = make(map[string]map[string]string)
}
t.ColTypes[colTypesKey] = colTypes
if t.ColTypes == nil {
t.ColTypes = make(map[string]map[string]string)
}
t.ColTypes[colTypesKey] = colTypes

actualPrivs, err := queries.CheckUserPrivileges(t.Ctx, conn, user, schema, table)
if err != nil {
return fmt.Errorf("failed to check user privileges on node %s: %w", hostname, err)
}
actualPrivs, err := queries.CheckUserPrivileges(t.Ctx, conn, user, schema, table)
if err != nil {
return fmt.Errorf("failed to check user privileges on node %s: %w", hostname, err)
}

if !actualPrivs.TableSelect {
return fmt.Errorf("user \"%s\" does not have the necessary privileges to run table-diff on table \"%s.%s\" on node \"%s\"",
user, schema, table, hostname)
}
if !actualPrivs.TableSelect {
return fmt.Errorf("user \"%s\" does not have the necessary privileges to run table-diff on table \"%s.%s\" on node \"%s\"",
user, schema, table, hostname)
}

hostMap[hostIP+":"+port] = hostname
hostMap[hostIP+":"+port] = hostname

if t.TableFilter != "" {
logger.Info("Applying table filter for diff: %s", t.TableFilter)
if t.TableFilter != "" {
logger.Info("Applying table filter for diff: %s", t.TableFilter)
}
return nil
}(); err != nil {
return err
}

conn.Close()
}

logger.Info("Connections successful to nodes in cluster")
Expand Down
Loading
Loading