Skip to content

Port lolor to PostgreSQL 19: drop PointerIsValid() #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mason-sharp merged 1 commit into from
Jul 6, 2026
Merged

Port lolor to PostgreSQL 19: drop PointerIsValid() #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/lolor_inv_api.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@ lolor_inv_open(Oid lobjId, int flags, MemoryContext mcxt)
void
lolor_inv_close(LargeObjectDesc *obj_desc)
{
Assert(PointerIsValid(obj_desc));
Assert(obj_desc);
pfree(obj_desc);
}

Expand Down Expand Up @@ -382,7 +382,7 @@ inv_getsize(LargeObjectDesc *obj_desc)
SysScanDesc sd;
HeapTuple tuple;

Assert(PointerIsValid(obj_desc));
Assert(obj_desc);

open_lo_relation();

Expand Down Expand Up @@ -427,7 +427,7 @@ lolor_inv_seek(LargeObjectDesc *obj_desc, int64 offset, int whence)
{
int64 newoffset;

Assert(PointerIsValid(obj_desc));
Assert(obj_desc);

/*
* We allow seek/tell if you have either read or write permission, so no
Expand Down Expand Up @@ -474,7 +474,7 @@ lolor_inv_seek(LargeObjectDesc *obj_desc, int64 offset, int whence)
int64
lolor_inv_tell(LargeObjectDesc *obj_desc)
{
Assert(PointerIsValid(obj_desc));
Assert(obj_desc);

/*
* We allow seek/tell if you have either read or write permission, so no
Expand All @@ -497,7 +497,7 @@ lolor_inv_read(LargeObjectDesc *obj_desc, char *buf, int nbytes)
SysScanDesc sd;
HeapTuple tuple;

Assert(PointerIsValid(obj_desc));
Assert(obj_desc);
Assert(buf != NULL);

if ((obj_desc->flags & IFS_RDLOCK) == 0)
Expand Down Expand Up @@ -608,7 +608,7 @@ lolor_inv_write(LargeObjectDesc *obj_desc, const char *buf, int nbytes)
bool replace[Natts_pg_largeobject];
CatalogIndexState indstate;

Assert(PointerIsValid(obj_desc));
Assert(obj_desc);
Assert(buf != NULL);

/* enforce writability because snapshot is probably wrong otherwise */
Expand Down Expand Up @@ -804,7 +804,7 @@ lolor_inv_truncate(LargeObjectDesc *obj_desc, int64 len)
bool replace[Natts_pg_largeobject];
CatalogIndexState indstate;

Assert(PointerIsValid(obj_desc));
Assert(obj_desc);

/* enforce writability because snapshot is probably wrong otherwise */
if ((obj_desc->flags & IFS_WRLOCK) == 0)
Expand Down
Loading