Some fixes and improvements#36
Open
lem21h wants to merge 5 commits into
Open
Conversation
… r.current could lead to discarding metadata without returning it to pool if it came from pool, fix panic in some methods
… enough and could case panic on malformed markers and partially mutate o.Marker if the marker tag is invalid
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
General set of updates to prevent code panic due to some cases.
Added some improvements to reduce amount of created GoRoutines in some functions - more work needed
Motivation and Context
Want to make this project better and readable
How to test this PR?
Just run the tests
Types of changes
Checklist:
commit-idorPR #here)