[Method Browser] Cleaning code and adding button feature#1384
Merged
Ducasse merged 3 commits intopharo-spec:Pharo14from Apr 23, 2026
Merged
[Method Browser] Cleaning code and adding button feature#1384Ducasse merged 3 commits intopharo-spec:Pharo14from
Ducasse merged 3 commits intopharo-spec:Pharo14from
Conversation
- Removed unused method for technical debt - Some methods used `System Navigation new` instead of the default one, fixed - New `Run Tests` button in the toolbar to run all test methods present in the browser instance - Removed `windowIsClosing`, there was 2 different call sites to handle window closing in the code, I moved all the logic in `initializeWindow:`
Contributor
|
argh we get a conflict. |
Contributor
Author
|
I solved it :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
System Navigation newinstead of the default one, fixedRun Testsbutton in the toolbar to run all test methods present in the browser instancewindowIsClosing, there was 2 different call sites to handle window closing in the code, I moved all the logic ininitializeWindow: