[Method Browser] Refactoring command migration#1394
Merged
Ducasse merged 10 commits intopharo-spec:Pharo14from Apr 23, 2026
Merged
[Method Browser] Refactoring command migration#1394Ducasse merged 10 commits intopharo-spec:Pharo14from
Ducasse merged 10 commits intopharo-spec:Pharo14from
Conversation
So it is more related to what already exist for the UI
Start of refactoring commands migration from Calypso to Spec ! This is a good setup in order to use them for the MethodBrowser. If there are broken tests it may be because the command classes need to be merged in Spec repository.
This reverts commit cfcfd47.
Contributor
|
oops there is a conflict |
Contributor
Author
|
It is fixed! |
Contributor
|
Strange I see |
Contributor
Author
|
@Ducasse it is linked to Esteban changes with the new SpCodeEditorPresenter |
Contributor
Author
|
I fixed everything normally, all failing tests need pharo-spec/Spec#1892 to be merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Start of refactoring commands migration from Calypso to Spec !
This is a good setup in order to use them for the MethodBrowser ( not for playground or anything else yet, we need to provide a unified API so the commands don't raise errors).
If there are broken tests it may be because the command classes need to be merged in Spec repository.
(all failing tests will pass when pharo-spec/Spec#1892 will be merged)