Skip to content

[Method Browser] Refactoring command migration#1394

Merged
Ducasse merged 10 commits intopharo-spec:Pharo14from
AlexisCnockaert:methodBrowser/refactoringcommands
Apr 23, 2026
Merged

[Method Browser] Refactoring command migration#1394
Ducasse merged 10 commits intopharo-spec:Pharo14from
AlexisCnockaert:methodBrowser/refactoringcommands

Conversation

@AlexisCnockaert
Copy link
Copy Markdown
Contributor

Start of refactoring commands migration from Calypso to Spec !
This is a good setup in order to use them for the MethodBrowser ( not for playground or anything else yet, we need to provide a unified API so the commands don't raise errors).
If there are broken tests it may be because the command classes need to be merged in Spec repository.
(all failing tests will pass when pharo-spec/Spec#1892 will be merged)

AlexisCnockaert and others added 4 commits April 20, 2026 14:03
So it is more related to what already exist for the UI
Start of refactoring commands migration from Calypso to Spec !
This is a good setup in order to use them for the MethodBrowser.
If there are broken tests it may be because the command classes need to be merged in Spec repository.
@Ducasse
Copy link
Copy Markdown
Contributor

Ducasse commented Apr 21, 2026

oops there is a conflict

@AlexisCnockaert
Copy link
Copy Markdown
Contributor Author

It is fixed!

@AlexisCnockaert AlexisCnockaert requested a review from Ducasse April 21, 2026 18:31
@Ducasse
Copy link
Copy Markdown
Contributor

Ducasse commented Apr 21, 2026

Strange I see

StMethodBrowserTest
 ✗ #testExplicitBrowseClassNameAsLiteral (9ms)
 ✗ #testRefreshingBlockWithLiteralString (90ms)
 ✗ #testOpenWithoutMessageShouldNotDNU (61ms)
 ✗ #testExplicitBrowseCompiledMethods (5ms)
 ✗ #testHandleMethodModifiedRemovesSenderWhenNoLongerMatching (97ms)
 ✗ #testHandleMethodRemovedUpdatesSelection (13ms)
 ✗ #testBrowseClassNameAsLiteral (180ms)
 ✗ #testExplicitBrowseSenders (2ms)
 ✗ #testMethodBrowserImplementors (12ms)
 ✗ #testHandleMethodAddedAddsMatchingSender (88ms)
 ✗ #testBrowseReferencesToVariableInClass (3ms)
 ✗ #testExplicitBrowseClassNameAsClass (2ms)
 ✗ #testWindowTitleWithFilterRatio (89ms)
 ✗ #testHandleMethodRemovedRemovesMatchingMethod (12ms)
 ✗ #testBrowseClassNameAsClass (86ms)
 ✗ #testExplicitBrowseImplementors (3ms)
 ✗ #testMethodBrowserSenders (9ms)

@AlexisCnockaert
Copy link
Copy Markdown
Contributor Author

AlexisCnockaert commented Apr 22, 2026

@Ducasse it is linked to Esteban changes with the new SpCodeEditorPresenter

@AlexisCnockaert
Copy link
Copy Markdown
Contributor Author

AlexisCnockaert commented Apr 22, 2026

I fixed everything normally, all failing tests need pharo-spec/Spec#1892 to be merged

@Ducasse Ducasse merged commit aa82fd3 into pharo-spec:Pharo14 Apr 23, 2026
0 of 2 checks passed
@AlexisCnockaert AlexisCnockaert deleted the methodBrowser/refactoringcommands branch April 23, 2026 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants