Break up ship_ai_update_race, and some other fixes that snuck in (oops) - #213
Open
unofficial-fish wants to merge 1 commit into
Open
Break up ship_ai_update_race, and some other fixes that snuck in (oops)#213unofficial-fish wants to merge 1 commit into
unofficial-fish wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly,
ctrl-xctrl-va block out ofship_ai_update_raceeight times (and style cleanup afterwards.)ship_ai_update_raceshould be less intimidating to edit now (it used to have a dozen levels of indentation in places.)Additionally, some math at the end of
ship_ai_update_racegot simplified, andship_ai_case_in_sightis no longer using a switch statement. I don't know if there's much reason to strain these out and submit them separately, so they're here too.