Skip to content

More enums, fewer macros. - #215

Open
unofficial-fish wants to merge 1 commit into
phoboslab:masterfrom
unofficial-fish:enums_typedefs_and_macros
Open

More enums, fewer macros.#215
unofficial-fish wants to merge 1 commit into
phoboslab:masterfrom
unofficial-fish:enums_typedefs_and_macros

Conversation

@unofficial-fish

Copy link
Copy Markdown

This is a constellation of related changes.

  • Some macros are now enums.
  • Some bitflag macros are also now enums. I've seen mixed thoughts on doing this, but the scratch-built parts of wipeout-rewrite use this idiom, so this makes it consistent.
  • Removed some redundant parentheses. Enums do not have to worry about precedence.
  • Removed an unused macro.
  • Reorganized weapon.h since macros and enums mixed together looked strange.
  • Changed section flags to bitshift notation.
  • typedef particle_type_t - being as specific as possible with types seems like good practice to me. This could be applied to other enums.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant