More cleanup regarding headers, declarations, etc.#13
Open
pprindeville wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
@phokz This is the other bit of cleanup I was talking about. I've built it on Linux using gcc7 and later. |
pprindeville
force-pushed
the
const-strings
branch
4 times, most recently
from
80bac24 to
f260a38
Compare
Use ANSI prototypes for functions. Make sure <time.h> is included everywhere time() gets called. Don't use unsafe sprintf() but snprintf() instead. Use const char * strings where appropriate (i.e. where arguments don't get modified as side-effects). Signed-off-by: Philip Prindeville <philipp@redfish-solutions.com>
pprindeville
force-pushed
the
const-strings
branch
from
f260a38 to
4479253
Compare
Contributor
Author
|
Any issues with this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use ANSI prototypes for functions. Make sure <time.h> is included
everywhere time() gets called. Don't use unsafe sprintf() but
snprintf() instead. Use const char * strings where appropriate
(i.e. where arguments don't get modified as side-effects).
Signed-off-by: Philip Prindeville philipp@redfish-solutions.com