Feature/379 385 list default layout#390
Open
carbontwelve wants to merge 18 commits into
Open
Conversation
... have updated #379 because I noticed that page-index.njk and page-list.njk are duplicate functionality and may be merged.
... pulled out debug.njk into own component because I will be using this to debug merging of page-index.njk with page-list.njk in future commits.
... this stops us from having issues with Nunjucks and async promise resolving within templates. Instead of the template waiting for the result of the filter function, the function instead returns what the image src will be and enqueues processing the screenshot which will happen during the `eleventy.after` lifecycle hook.
…ex page. ... this completes #385
... 11ty processes global data files found in the `_data` directory first, which makes the data available to collections. Not sure *why* I was loading it via the 11tydata but it meant that for books the lists template was unable to count how many items it contained. With this change it can now.
…out' into feature/379-385-list-default-layout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.