fix: don't treat an already-run migration as unrecognised#1401
Merged
dantownsend merged 2 commits intoJul 20, 2026
Conversation
When a specific migration ID is requested via the forwards command and it has already run, Piccolo now exits successfully with no migrations to run. Fixes piccolo-orm#1359
dantownsend
marked this pull request as ready for review
July 20, 2026 14:22
Member
|
Thanks for this. I think what you did was great, but I tweaked it a tiny bit just for personal preference. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1359
When a specific migration ID passed to
piccolo migrations forwardshas already been run, the command now exits successfully and reports that no migrations need to be run, instead of printing<id> is unrecognisedand returning an error status.