Fix KL42x/KL43x light strips: use lightStrip module for light state - #117
Merged
Conversation
The smartbulb lightingservice module returns err_code -2001 ('module not
support') on these devices; they respond to smartlife.iot.lightStrip with
set_light_state. Verified against a live KL420L5(US): get_light_state and
set_light_state (on_off 0/1) both succeed, transition_light_state via the
smartbulb module does not.
piekstra-dev
approved these changes
Aug 13, 2026
piekstra-dev
left a comment
piekstra-dev
left a comment
Collaborator
There was a problem hiding this comment.
Automated PR Review
Reviewed commit: d0770420452c
Profile: reviewer - Posting as: piekstra-dev
Summary
| Reviewer | Findings |
|---|---|
| python:implementation | 0 |
Reviewer Coverage
python:implementation— complete (broad); skipped: none; constraints: git diff against the base SHA was blocked by tool approval; review is based on the full current file contents of the three assigned files rather than a line-level diff.
Inspected files (3)
tests/test_device_types.pytplinkcloud/kl420l5.pytplinkcloud/kl430.py
0 PR discussion threads considered. 0 summarized; 0 resolved.
Completed in 1m 25s | $0.59 | claude-sonnet-5 | cr 0.10.286
| Field | Value |
|---|---|
| Model | claude-sonnet-5 |
| Reviewers | python:implementation |
| Engine | claude_cli · claude-sonnet-5 |
| Reviewed by | cr · piekstra-dev |
| Duration | 1m 25s wall · 1m 21s compute |
| Cost | $0.59 |
| Tokens | 38 in / 5.3k out |
Per-workstream usage
orchestrator-selection— claude-sonnet-5- In: 6
- Out: 891
- Cache read: 66.0k
- Cache create: 15.3k
- Cost: $0.13
- Duration: 15s
python:implementation— claude-sonnet-5- In: 26
- Out: 4.1k
- Cache read: 432.8k
- Cache create: 22.7k
- Cost: $0.33
- Duration: 55s
orchestrator-rollup— claude-sonnet-5- In: 6
- Out: 357
- Cache read: 80.3k
- Cache create: 17.5k
- Cost: $0.13
- Duration: 9s
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
KL420L5/KL430 light-state commands were sent to
smartlife.iot.smartbulb.lightingservice/transition_light_state, which these devices reject witherr_code -2001("module not support"). They respond tosmartlife.iot.lightStrip/set_light_state.Affects
power_on/power_off/toggle,get_light_state/set_light_state,set_brightness/set_color/set_color_tempon both classes.Verification
get_light_stateandset_light_state(on_off 0/1) succeed through the lightStrip module; the smartbulb module returns -2001. KL430 is inferred from the shared hardware family (its tests were wiremock-only before this change too).Suggest releasing as v5.2.1 — downstream, tplinkcloud-service's bulb toggle depends on it.