Replace split(/\s+/) to allow for spaces in file names & paths when using datafile #91
Open
asp55 wants to merge 1 commit intopiqnt:masterfrom
Open
Replace split(/\s+/) to allow for spaces in file names & paths when using datafile #91asp55 wants to merge 1 commit intopiqnt:masterfrom
split(/\s+/) to allow for spaces in file names & paths when using datafile #91asp55 wants to merge 1 commit intopiqnt:masterfrom
Conversation
…eplace(/"([^"]+)"|'([^']+)'/g,"$1$2"))` to split only on spaces not wrapped in quotes to allow for spaces in file names & paths
Collaborator
|
Thanks, could we use a library instead? |
Author
|
Not sure I follow what you'd be using a library to do. The existing use of split(/\s+/) in splitParams function makes it so that if you're using a datafile to do your configuration and you have a space in a file path, it'll split that as well. In the replacement line: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
split(/\s+/)withmatch(/\w+|"[^"]+"|'[^']+'/g).map(v=>v.replace(/"([^"]+)"|'([^']+)'/g,"$1$2"))to split only on spaces not wrapped in quotes to allow for spaces in file names & paths