Skip to content

Try workaround for Clickhouse issue with cancelling https queries #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
apata wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Try workaround for Clickhouse issue with cancelling https queries #299

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 25 additions & 2 deletions lib/ch/connection.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,14 +347,37 @@ defmodule Ch.Connection do
end
end

defp get_disconnect_mode(
%HTTP{
scheme_as_string: "https",
private: %{settings: settings}
} = _conn
)
when is_list(settings) do
if {:cancel_http_readonly_queries_on_client_close, 1} in settings and
({:readonly, 1} in settings or {:readonly, 2} in settings) do
:ungraceful
else
:graceful
end
end

defp get_disconnect_mode(_conn), do: :graceful

@impl true
def disconnect(error, {conn, _reader}) do
disconnect(error, conn)
end

def disconnect(_error, conn) do
{:ok = ok, _conn} = HTTP.close(conn)
ok
case get_disconnect_mode(conn) do
:ungraceful ->
:ok

:graceful ->
{:ok, _conn} = HTTP.close(conn)
:ok
end
end

@typep response :: Mint.Types.status() | Mint.Types.headers() | binary
Expand Down