Conversation
davisagli
left a comment
davisagli
left a comment
There was a problem hiding this comment.
I have not tested it, but the direction makes sense.
|
Tested project generation, docs with |
Yes, for now a new Volto add-on comes with zero tests. |
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
ericof
changed the title
stevepiercy
left a comment
stevepiercy
left a comment
There was a problem hiding this comment.
I'm concerned that the instructions to install the add-on for both Volto 17 and 18 do not align with official documentation. See:
@sneridagh and I recently revised that document. Let's make sure he does a thorough review of this. I'm OK with keeping the customized instructions where the project name gets substituted, but let's make sure they are correct and aligned with official docs.
| The development of this add-on is done in isolation using pnpm workspaces, the latest `mrs-developer`, and other Volto core improvements. | ||
| For these reasons, it only works with pnpm and Volto 18. |
There was a problem hiding this comment.
This doesn't make sense. We have instructions for both Volto 17 and 18, but then say development of the add-on can be done only in Volto 18. I'm not sure what to do here.
Do we actually support Volto 17 with this Cookieplone template?
There was a problem hiding this comment.
Add-ons developed with Cookieplone could work with Volto 17
There was a problem hiding this comment.
Then we should remove this section, right? We can't say both it works only for 18, then it also could work for 17. Maybe we just refer to the official docs?
@sneridagh @davisagli what do you think?
There was a problem hiding this comment.
Let's open a other issue to review all the README files?
The original goal of this PR was to make sure all references to the repository url were consistent within a project, but now we are trying to address all the other issues we have in docs :-)
Co-authored-by: Steve Piercy <web@stevepiercy.com>
| The development of this add-on is done in isolation using pnpm workspaces, the latest `mrs-developer`, and other Volto core improvements. | ||
| For these reasons, it only works with pnpm and Volto 18. |
There was a problem hiding this comment.
Then we should remove this section, right? We can't say both it works only for 18, then it also could work for 17. Maybe we just refer to the official docs?
@sneridagh @davisagli what do you think?
…}/backend/README.md Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
3 participants
I'm trying to make sure every reference to the repository url is consistent when we create a project.
I also fixed an issue with the backend towncrier template
Fixes #221