Conversation
… displayed within the shadow dom
# Conflicts: # apps/seven/app/root.tsx # packages/cmsui/routes/layout.tsx # packages/layout/components/Toolbar/Toolbar.tsx # packages/publicui/routes/index.tsx
stevepiercy
left a comment
stevepiercy
left a comment
There was a problem hiding this comment.
I started a review and made a few trivial suggestions, but then realized the PR code should get a technical review before I go all in.
Additionally, we need to decide where to put documentation.
Should docs/configuration be a reference or how-to guide?
I read it as a how-to guide, so I'd suggest nesting this directory of files as:
docs/how-to/configuration/
@sneridagh @pnicolli what do you think?
| You can customize a component without using {term}`shadowing` at all, if the code that calls the component retrieves the information of the component to use from the component registry. | ||
| The {term}`configuration registry` includes a component registry for managing components globally. | ||
| In this registry, components can be registered given a unique component name. | ||
| Any other add-on can then retrieve and use this component by searching the components name. |
There was a problem hiding this comment.
| Any other add-on can then retrieve and use this component by searching the components name. | |
| Any other add-on can then retrieve and use this component by searching for the component's name. |
There was a problem hiding this comment.
@sneridagh @pnicolli @davisagli I like the revisions on this page, as it improves grammar and readability. Would you please check it for technical accuracy?
| You can register components, and retrieve them afterwards given a list of modifiers `dependencies`. | ||
|
|
||
| Components can also be conditionally registered by passing dependencies. | ||
| To register a component with dependencies, you can either pass a `string` or an `array of strings`. |
There was a problem hiding this comment.
Inline literals aren't necessary here. Also use the imperative form.
| To register a component with dependencies, you can either pass a `string` or an `array of strings`. | |
| To register a component with dependencies, either pass a string or an array of strings. | |
| @@ -0,0 +1 @@ | |||
| Extended customizability of the Menu component. @arybakov05 No newline at end of file | |||
There was a problem hiding this comment.
| Extended customizability of the Menu component. @arybakov05 | |
| Extended customizability of the `Menu` component. @arybakov05 |
packages/layout/news/6653.feature
Outdated
| @@ -0,0 +1,4 @@ | |||
| Replaced toolbar plugs with slots. | |||
| Wrapped toolbar in portal provider so that overlays are rendered inside the shadow root. | |||
| Added ToolbarMenu component to handle shadow root integration. | |||
There was a problem hiding this comment.
| Added ToolbarMenu component to handle shadow root integration. | |
| Added `ToolbarMenu` component to handle shadow root integration. |
|
@stevepiercy Before you go all in, there is still some documentation to be written on my changes regarding the Toolbar. When that's finished, I will mark the PR ready for review. |
3 participants
Closes #6653