Replace moment.js by using plone components widgets#8065
Replace moment.js by using plone components widgets#8065
Conversation
|
@tedw87 can you provide some screenshots? CI fails. Can you look into that? Finally, I don't know whether this aligns with the PLIP PLIP - plone.app.event based types (view). Does this PR close any related issue? Personally, I love the idea of removing moment.js. |
Co-authored-by: Steve Piercy <web@stevepiercy.com>
stevepiercy
left a comment
There was a problem hiding this comment.
News LGTM. Needs technical review and check with compliance with open PLIP.
Yes, I am working on fixing CI and I will also look into PLIP - plone.app.event based types (view) to see if I can touch that issue too, with this PR. |
If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.
Closes #
If your pull request includes changes to the documentation—either in narrative documentation, Storybook, or configuration—then a pull request preview will be generated and a link will populate in the description of your pull request below.
By clicking that link, you can use the visual diff menu in the upper right corner to navigate to pages that have changes, then display the diff by checking the
Show diffcheckbox.