Skip to content

Replace moment.js by using plone components widgets#8065

Open
tedw87 wants to merge 12 commits intomainfrom
date-quanta-widgets
Open

Replace moment.js by using plone components widgets#8065
tedw87 wants to merge 12 commits intomainfrom
date-quanta-widgets

Conversation

@tedw87
Copy link
Copy Markdown
Contributor

@tedw87 tedw87 commented Mar 31, 2026


If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.

Closes #


If your pull request includes changes to the documentation—either in narrative documentation, Storybook, or configuration—then a pull request preview will be generated and a link will populate in the description of your pull request below.
By clicking that link, you can use the visual diff menu in the upper right corner to navigate to pages that have changes, then display the diff by checking the Show diff checkbox.

@tedw87 tedw87 changed the title use DateTimePicker.quanta.tsx in datetime widgets Replace moment.js by using plone components widgets Mar 31, 2026
@stevepiercy
Copy link
Copy Markdown
Collaborator

@tedw87 can you provide some screenshots?

CI fails. Can you look into that?

Finally, I don't know whether this aligns with the PLIP PLIP - plone.app.event based types (view). Does this PR close any related issue?

Personally, I love the idea of removing moment.js.

tedw87 and others added 2 commits March 31, 2026 15:04
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Copy link
Copy Markdown
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

News LGTM. Needs technical review and check with compliance with open PLIP.

@tedw87
Copy link
Copy Markdown
Contributor Author

tedw87 commented Mar 31, 2026

@tedw87 can you provide some screenshots?

CI fails. Can you look into that?

Finally, I don't know whether this aligns with the PLIP PLIP - plone.app.event based types (view). Does this PR close any related issue?

Personally, I love the idea of removing moment.js.

Yes, I am working on fixing CI and I will also look into PLIP - plone.app.event based types (view) to see if I can touch that issue too, with this PR.
Thank you for the comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants