Conversation
davisagli
force-pushed
the
dep-webpack-dev-server
branch
from
f96456a to
f6d1111
Compare
wesleybl
requested changes
Apr 8, 2026
davisagli
force-pushed
the
dep-webpack-dev-server
branch
from
f6d1111 to
5b16fcf
Compare
davisagli
force-pushed
the
dep-webpack-dev-server
branch
from
5b16fcf to
cba1352
Compare
Member
Author
|
@wesleybl Thanks for the review! |
* main: Bump vite from 6.4.1 to 6.4.2 (#8082)
sneridagh
approved these changes
Apr 8, 2026
Member
There was a problem hiding this comment.
LGTM! Sorry for taking so long to review. Works great (HMR refresh too) and I tested in a project already and all seems ok.
@davisagli @wesleybl I added a small thing, since in 19.0.0-alpha.28 I detected a problem in projects using it related to having several webpack versions active in the same build. I pinned webpack in the catalog as well.
I will wait until you both give me your approval to that last change. I don't think that nobody is using 28 (yet). I will release asap I get your green light.
Member
Author
|
@sneridagh It makes sense to me to put webpack in the catalog. I'll merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And drop support for webpack 4 and webpack-dev-server 4 in volto-razzle and volto-razzle-dev-utils.