Skip to content

Fix controls rendering in StrictMode with R3F Canvas #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Fix controls rendering in StrictMode with R3F Canvas #574

Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1e2632e
Initial plan
Copilot Nov 2, 2025
1ee407b
Initial commit - planning fix for StrictMode rendering issue
Copilot Nov 2, 2025
95e75c0
Fix StrictMode rendering issue in useToggle hook
Copilot Nov 2, 2025
7f39ac5
Address code review feedback - remove duplicate assignment
Copilot Nov 2, 2025
2867f9f
Remove accidentally added empty yarn.lock file
Copilot Nov 2, 2025
d55010c
Add StrictMode reproduction story
Copilot Nov 8, 2025
4fcc479
Merge branch 'main' into copilot/fix-controls-rendering-issue
gsimone Nov 9, 2025
860b265
Add R3F Canvas reproduction to bug repros story
Copilot Nov 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions packages/leva/src/hooks/useToggle.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ import { useRef, useEffect, useLayoutEffect } from 'react'
export function useToggle(toggled: boolean) {
const wrapperRef = useRef<HTMLDivElement>(null)
const contentRef = useRef<HTMLDivElement>(null)
const firstRender = useRef(true)
const prevToggledRef = useRef<boolean | null>(null)

// this should be fine for SSR since the store is set in useEffect and
// therefore the pane doesn't show on first render.
Expand All @@ -94,9 +94,11 @@ export function useToggle(toggled: boolean) {
}, [])

useEffect(() => {
// prevents first animation
if (firstRender.current) {
firstRender.current = false
// On initial render (including StrictMode's double-invocation),
// prevToggledRef.current is null, so we skip animation.
// We only animate when toggled actually changes from a previous value.
if (prevToggledRef.current === null || prevToggledRef.current === toggled) {
prevToggledRef.current = toggled
return
}

Expand All @@ -120,6 +122,8 @@ export function useToggle(toggled: boolean) {
timeout = window.setTimeout(() => (ref.style.height = '0px'), 50)
}

prevToggledRef.current = toggled

return () => {
ref.removeEventListener('transitionend', fixHeight)
clearTimeout(timeout)
Expand Down