Updates sign in confirmation page - #859
Open
Adam-it wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Aim
Is to update the sign in confirmation page to something a bit nicer. Now it is a standard HTML page with a single text and does not look profesional.
🧪 How to test
since mode of the change was done on CLI for M365 for SPFx Toolkit npm package side, you simply need to pull the changes, run npm ci and run the VS Code extension in debug and perform sign in
📷 Result
new sign in confirmation page

after a short wait it will redirect to https://spfxtoolkit.community.ms/