storage/overlay: use userxattr when probing idmapped lower layers - #1022
Open
tim-day-387 wants to merge 1 commit into
Open
storage/overlay: use userxattr when probing idmapped lower layers#1022tim-day-387 wants to merge 1 commit into
tim-day-387 wants to merge 1 commit into
Conversation
supportsIdmappedLowerLayers() performs a test overlay mount to detect whether the kernel supports idmapped lower layers. When running rootless, the kernel requires the userxattr mount option for unprivileged overlay mounts, so the probe mount always failed and rootless podman incorrectly reported idmapped mounts as unsupported. Pass userxattr in the probe mount options when running rootless, so the check reflects actual kernel support. Fixes: 9eb030e ("overlay: use idmapped lower layers where supported") Signed-off-by: Timothy Day <timday@thelustrecollective.com>
giuseppe
approved these changes
Jul 27, 2026
giuseppe
left a comment
giuseppe
left a comment
Contributor
There was a problem hiding this comment.
it shouldn't matter for the mount test, but doesn't hurt.
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the commit message:
This fix mirrors all of the other code paths for mounting overlay rootless. I've tested this on my local install and I see
/run/user/1000/containers/overlay/idmapped-lower-dir-trueget correctly populated.