pkg/retry: don't panic when the retry delay is too small for jitter - #1072
Open
ROKUMATE wants to merge 1 commit into
Open
pkg/retry: don't panic when the retry delay is too small for jitter#1072ROKUMATE wants to merge 1 commit into
ROKUMATE wants to merge 1 commit into
Conversation
giuseppe
reviewed
Aug 12, 2026
mtrmac
reviewed
Aug 12, 2026
Fixes: podman-container-tools#1071 Signed-off-by: ROKUMATE <rohitkumawat0110@gmail.com>
ROKUMATE
force-pushed
the
retry-no-panic-on-small-delay
branch
from
August 12, 2026 20:34
d0a4370 to
1be57f9
Compare
Author
|
i have addressed all the reviews in the next commit ... do tell if any more changes are required |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1071
rand.Npanics on a non-positive argument anddelay / 10is 0 below 10ns, so anyOptions.Delayunder that panickedIfNecessary. Negative delays too.Only jitter when there's a positive range to jitter over. No change at 10ns and above.
Reachable from
containers.conf:[engine] retry_delayis parsed withtime.ParseDurationand reachesOptions.Delaythrough libimage with no range check.The package had no tests, so this adds coverage for the delay handling:
1ns/5ns/9ns/10ns/negative, plus the default exponential path. Reverting the fix makes
them panic at
retry.go:51.