libimage: do not fail disk usage when an image is removed mid-walk - #1073
Open
vtushar06 wants to merge 2 commits into
Open
libimage: do not fail disk usage when an image is removed mid-walk#1073vtushar06 wants to merge 2 commits into
vtushar06 wants to merge 2 commits into
Conversation
giuseppe
reviewed
Aug 13, 2026
Signed-off-by: Tushar Verma <tusharmyself06@gmail.com>
Signed-off-by: Tushar Verma <tusharmyself06@gmail.com>
vtushar06
force-pushed
the
libimage-diskusage-removed-image
branch
from
August 13, 2026 16:30
dca9ffc to
4544bf0
Compare
Author
|
@giuseppe I think this will be ready, just waiting for workflow to pass out |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
podman system dfflakes in parallel CI runs when another test removes an image while df is walking the list:(from https://github.com/podman-container-tools/podman/actions/runs/29565253194/job/87336101705, and again on 07-21)
DiskUsagelists the images once, thendiskUsageForImagecallsisCorruptedper image, so anything removed between the two steps kills the whole command. Same shape as the volume flavor that 246724fc6 fixed on the podman side, just on the image path.Two small changes:
isCorruptedwraps with%winstead of%vso the error keeps its type, andDiskUsageskips an image only onErrImageUnknown. A genuinely corrupted image still fails -TestCorruptedLayersbuilds the missing-layer case and it passes unchanged, which I checked matters here because that error isErrLayerUnknown, notErrImageUnknown.The new test fails on the old code (
require.ErrorIscannot seeimage not knownthrough the%vwrap) and passes with the fix. Ran both tests on linux in a container.