events: fix goroutine leak with until flag in file backend - #29493
Draft
HindzStark wants to merge 1 commit into
Draft
events: fix goroutine leak with until flag in file backend#29493HindzStark wants to merge 1 commit into
HindzStark wants to merge 1 commit into
Conversation
Signed-off-by: dhruv <dhruvdkjk@gmail.com>
HindzStark
force-pushed
the
fix-event-until-leak
branch
from
August 13, 2026 09:49
2cec10d to
5cec7d6
Compare
Contributor
|
We have been getting a lot of low quality PRs that do not follow our contribution guidelines and LLM policy. Because our time is limit I reserve the right to just close these PRs without further comments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Fixed a goroutine and memory leak in the file events backend when using the
--untilflag.Previously,
libpod/events/logfile.gospawned an unmanaged goroutine usingtime.Sleep(time.Until(untilTime))that ignoredcontext.Contextcancellation. If a client disconnected early (e.g. dropped API connection orCtrl+C), the goroutine was orphaned and continued sleeping in the background.I replaced the blocking
time.Sleepwith atime.NewTimerand aselectblock that listens forctx.Done(). This ensures the goroutine exits immediately if the client cancels the request, properly freeing system resources and preventing an API denial-of-service vector.- How I did it
time.Sleepwithtime.NewTimer.selectstatement listening to<-ctx.Done()and<-timer.C.- How to verify it
podman system servicecurl -v --unix-socket /run/user/1000/podman/podman.sock "http://d/v4.0.0/libpod/events?until=9999h"Ctrl+C).- Description for the changelog