exec: forward signals to the exec session's process group - #29525
Open
sahilnyk wants to merge 1 commit into
Open
exec: forward signals to the exec session's process group#29525sahilnyk wants to merge 1 commit into
sahilnyk wants to merge 1 commit into
Conversation
Fixes: podman-container-tools#19486 Signed-off-by: Sahil Nayak <contactsahilpnayak@gmail.com>
sahilnyk
force-pushed
the
exec-sigproxy-pgid
branch
from
August 14, 2026 18:43
1147aab to
2ae8cf4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #19486
Killing
podman execleft the command it started running inside the container, because the signal was never passed on.It now signals the process group of the exec'd command. The kernel already puts that command and its children in one group, so there is no process tree to walk.
podman exec --no-sessionhad the same bug and is fixed too.Tested on runc and crun, rootless and rootful. The new case in
032-sig-proxy.batsfails without this change.Checklist
git commit -s). The author email must match the sign-off email address. See CONTRIBUTING.md.Fixes: #00000in commit message (if applicable)make validatepr(format/lint checks)Noneif no user-facing changes)Does this PR introduce a user-facing change?