Skip to content

Performance: Replace strings.ToLower with strings.EqualFold - #29527

Merged
Honny1 merged 1 commit into
podman-container-tools:mainfrom
vishnukothakapu:perf-strings-equalfold
Aug 17, 2026
Merged

Performance: Replace strings.ToLower with strings.EqualFold#29527
Honny1 merged 1 commit into
podman-container-tools:mainfrom
vishnukothakapu:perf-strings-equalfold

Conversation

@vishnukothakapu

Copy link
Copy Markdown
Contributor

Replaces unnecessary heap allocations for case-insensitive equality checks with standard library strings.EqualFold.

Fixes: #29526

Checklist

Ensure you have completed the following checklist for your pull request to be reviewed:

  • I have read and understood our contributing guidelines and will not have more than two open PRs as a new contributor.
  • PR description, commit message, and GitHub comments are human-written, per LLM Policy
  • Certify you wrote the patch or otherwise have the right to pass it on as an open-source patch by signing all
    commits. (git commit -s). (If needed, use git commit -s --amend). The author email must match
    the sign-off email address. See CONTRIBUTING.md
    for more information.
  • Referenced issues using Fixes: #29526 in commit message (if applicable)
  • Tests have been added/updated (or no tests are needed)
  • Documentation has been updated (or no documentation changes are needed)
  • All commits pass make validatepr (format/lint checks)
  • Release note entered in the section below (or None if no user-facing changes)

Does this PR introduce a user-facing change?

None

Replaces unnecessary heap allocations for case-insensitive equality
checks with standard library strings.EqualFold.

Fixes: podman-container-tools#29526
Signed-off-by: Vishnu Kothakapu <vishnukothakapu27@gmail.com>

@mheon mheon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mheon mheon added the No New Tests Allow PR to proceed without adding regression tests label Aug 14, 2026

@Honny1 Honny1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Honny1
Honny1 enabled auto-merge August 17, 2026 12:08
@Honny1
Honny1 merged commit 4b6873a into podman-container-tools:main Aug 17, 2026
195 of 204 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

machine No New Tests Allow PR to proceed without adding regression tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Performance: Replace strings.ToLower() == with strings.EqualFold() to prevent unnecessary allocations

3 participants