hack/ci: pass --remote to bud tests - #29529
Open
vtushar06 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Tushar Verma <tusharmyself06@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
bud remotejob runs the same local binary asbud local. Both jobs from run 31847250452 on main print the identical bats invocation:bin/podman, notpodman-remote, andREMOTE=empty, in the job named remote.The remote path in
run-buildah-bud-testsis gated onPODBIN_NAME(line 78), which Cirrus used to set per matrix task. The migration replaced that with amode:matrix key, butrun_bud()never reads$MODE-run_int,run_sys,run_machineandrun_upgradeall do.grep -rn PODBIN_NAMEoutside vendor finds it only insiderun-buildah-bud-testsitself and in the treadmill script's Cirrus text.So
apply-podman-deltashas 30skip_if_remoteand 4skip_if_rootless_remoteentries that are currently no-ops, and podman-remote build coverage has been off since the migration.--remoteis already an option on the script and setsPODBIN_NAME=remotebefore that gate, so this is one branch inrun_bud.Worth saying plainly: this restores coverage rather than being a no-op, so the remote leg may go red on things that have been hidden. Most of the historically broken ones should already be covered by those deltas, but if new failures show up I am happy to iterate on them here or in a follow-up.