machine/wsl: unregister shared net-usermode dist on machine rm - #29533
Open
Srujansa wants to merge 1 commit into
Open
machine/wsl: unregister shared net-usermode dist on machine rm#29533Srujansa wants to merge 1 commit into
Srujansa wants to merge 1 commit into
Conversation
Signed-off-by: Srujansa <srujan3255@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #29480
The
podman-net-usermodeWSL distribution is shared across allmachines using
--user-mode-networking, butpodman machine rmnever unregistered it — only the machine's own WSL distro was
removed, leaving
podman-net-usermodebehind indefinitely.This adds a check in
WSLStubber.Remove(): if the removed machinehad user-mode networking enabled, it now looks at the other
configured machines and only unregisters
podman-net-usermodeifnone of them still need it.
Tested manually on Windows:
--user-mode-networking:podman machine rmnow also removes
podman-net-usermodefromwsl --list--user-mode-networking: removing oneleaves
podman-net-usermodeintact for the other