Skip to content

refactor: remove redundant err.Error() calls - #29539

Open
ravencore06 wants to merge 1 commit into
podman-container-tools:mainfrom
ravencore06:refactor/remove-redundant-error-formatting
Open

refactor: remove redundant err.Error() calls#29539
ravencore06 wants to merge 1 commit into
podman-container-tools:mainfrom
ravencore06:refactor/remove-redundant-error-formatting

Conversation

@ravencore06

Copy link
Copy Markdown

Description

Remove redundant err.Error() calls when formatting errors in
cmd/podman/root.go and pkg/domain/infra/abi/generate.go.

The errors are passed directly to the formatting functions using %v,
following idiomatic Go error formatting and the existing Podman style.

Changes

  • Replace redundant err.Error() calls with %v and err.
  • No functional behavior is changed.
  • No unrelated code was modified.

Validation

  • git diff --check passes.
  • Local Go tests were not run because Go is not installed in the current development environment.

@Honny1 Honny1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first glance, the idea/code of change seems to be correct. But please follow our contribution guidelines and LLM policy.

For example, please squash all commits and refer to the issue (if exsits) in the commit msg in way Fixes: #NUMBER_OF_ISSUE, properly sign the commit, etc.

@ravencore06
ravencore06 requested a review from Honny1 August 17, 2026 12:50
Fixes: podman-container-tools#29265
Signed-off-by: Srinidhi <srinidhisadhanala@gmail.com>
@ravencore06
ravencore06 force-pushed the refactor/remove-redundant-error-formatting branch from 706a74f to 20eb582 Compare August 17, 2026 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants