refactor: Prefer consistent use of "function" pattern instead of nonlocal - #185
Merged
Merged
Conversation
alexander-beedie
force-pushed
the
prefer-func-pattern
branch
from
June 18, 2026 06:23
18db293 to
b48982d
Compare
|
Could this get reviewer(s)? Current benchmark workflow fails at Dask Q1 and never reaches Modin, but still reports success. This PR fixes callable rebinding behind that failure and unblocks follow-up work to make benchmark CI status truthful. cc: @ritchie46 , @orlp |
orlp
requested changes
Sep 3, 2026
orlp
left a comment
orlp
left a comment
Member
There was a problem hiding this comment.
The nonlocal stuff seems fine to me but the modin changes really should be its own PR.
alexander-beedie
force-pushed
the
prefer-func-pattern
branch
from
September 4, 2026 07:59
b48982d to
fdacd3c
Compare
alexander-beedie
force-pushed
the
prefer-func-pattern
branch
from
September 4, 2026 07:59
fdacd3c to
195655a
Compare
Contributor
Author
Yup, good call; split out into #195 👌 |
orlp
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made the function pattern consistent across all benchmarks - the
nonlocaloverwrite can cause issues with multiple runs in a single session. We already use the function pattern in an other queries/tests, so this is consistent as well as fixing some edge-cases.Also fixes some benchmarks running on macOS (ref: "MODIN_MEMORY" env).