Fix range parser bug with KJs+ and KQo+ including invalid hands - #58
Merged
Conversation
- Fix _expand_suited_plus and _expand_offsuit_plus to exclude kickers higher than the high rank (e.g., KAs when high is K) - Normalize Hand.from_string to ensure rank1 >= rank2 (higher rank first) - Add integration test reproducing the issue - Add unit tests for edge cases with K high rank Closes issue with range parser including invalid hands like KAs and KAo when parsing ranges like KJs+ and KQo+ Co-authored-by: polmichel <polmichel@users.noreply.github.com>
polmichel
force-pushed
the
fix/range-parser-bug
branch
from
August 19, 2026 21:38
1e43d8e to
b41e84b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix range parser to exclude invalid hands like KAs and KAo when parsing ranges like KJs+ and KQo+.
Changes
Issue
When parsing range notation like , the parser was incorrectly including invalid hands such as KAs and KAo (where A > K, so the hand should be AKs/AKo, not KAs/KAo).
This was causing incorrect equity calculations and missing database entries.
Closes issue with range parser