Release 2.0.0: PHP ^8.2, portphp ^2.0, Symfony Console 5.4–8 - #13
Merged
Conversation
Breaking major: drop PHP < 8.2, portphp 1.x, and old Symfony Console lines. Add void return types, Dependabot, modern README and CI.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR prepares the 2.0.0 release by aligning this package with portphp/portphp 2.x and modernizing compatibility/docs/CI configuration for PHP 8.2+ and Symfony Console 5.4–8.
Changes:
- Bump platform and library requirements (PHP
^8.2,portphp/portphp^2.0,symfony/console^5.4 || ^6 || ^7 || ^8) and document the upgrade path. - Update writers to use
: voidreturn types on core writer methods. - Refresh project metadata/docs and adjust tooling config (PhpSpec suites, removal of Scrutinizer config, GitHub Actions/Dependabot files added/updated).
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| UPGRADE-2.0.md | Adds a short upgrade guide for the 2.0 breaking changes. |
| src/TableWriter.php | Adds : void return types to writer methods. |
| src/ProgressWriter.php | Adds : void return types to writer methods. |
| README.md | Modernizes badges/links and states updated requirements. |
| phpspec.yml.dist | Updates PhpSpec suite naming/structure. |
| phpspec.yml.ci | Updates CI PhpSpec config and removes coverage extension config. |
| composer.json | Updates dependency constraints and dev requirements for 2.0. |
| .scrutinizer.yml | Removes Scrutinizer configuration. |
| .github/workflows/checks.yml | Replaces legacy CI config (currently ends up empty in this diff). |
| .github/dependabot.yml | Adds Dependabot file (currently ends up empty in this diff). |
| .gitattributes | Updates export-ignore list to reflect removed CI/Scrutinizer files. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -1,42 +1 @@ | |||
| name: Checks | |||
|
|
|||
| @@ -0,0 +1 @@ | |||
|
|
|||
Comment on lines
36
to
38
| public function writeItem(array $item): void | ||
| { | ||
|
|
Comment on lines
+50
to
+51
| public function finish(): void | ||
| { |
Comment on lines
63
to
64
| public function prepare(): void | ||
| { |
Comment on lines
74
to
75
| public function writeItem(array $item): void | ||
| { |
Comment on lines
82
to
83
| public function finish(): void | ||
| { |
Empty workflow files were committed by mistake; restore full definitions. Match existing same-line brace style for Writer methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Major aligned with
portphp/portphp2.0.Breaking
php:^8.2portphp/portphp:^2.0symfony/console:^5.4 || ^6.0 || ^7.0 || ^8.0: voidreturn typesOther
UPGRADE-2.0.mdPlease do not merge until approved.