Skip to content

[G2M] fix - Deleting a project should not delete all stages and their KVs under a team - #52

Open
ashishjullia wants to merge 1 commit into
portunus-dev:mainfrom
ashishjullia:fix-projects
Open

[G2M] fix - Deleting a project should not delete all stages and their KVs under a team#52
ashishjullia wants to merge 1 commit into
portunus-dev:mainfrom
ashishjullia:fix-projects

Conversation

@ashishjullia

Copy link
Copy Markdown
Contributor

Problem:
Because of

const stageKeys = await STAGES.list({ prefix: `${team}::` });
, this
return Promise.all([STAGES.delete(name), KV.delete(name)]);
will delete all stages and their KVs under a team

Fix:
Updated updateProjectName to handle project key's actual value update for an update project name and then for deleteProject's bug only delete those stages and KVs and not all

…alue update for an update project name and then for deleteProject's bug only delete those stages and KVs and not all
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant