Database Modernization (insertOrIgnore, Upsert, Interfaces, PDO Db Capabilities [centralization], unit tests)#1088
Draft
belisoful wants to merge 53 commits intopradosoft:masterfrom
Draft
Database Modernization (insertOrIgnore, Upsert, Interfaces, PDO Db Capabilities [centralization], unit tests)#1088belisoful wants to merge 53 commits intopradosoft:masterfrom
belisoful wants to merge 53 commits intopradosoft:masterfrom
Conversation
Adds insertOrIgnore and upsert to: TActiveRecord, TDbCommandBuilder, TDataGatewayCommand, TTableGateway, and SqlMap. TTableGateway adds getTableExists. DbSpecific unit tests. ActiveRecord, SqlMap, and TTableGateway::tableExists, DBSpecific unit tests
Adds TDbDriver to unify Driver Names with refactor. TDbSerialTransaction renews transactions on rollback/commit. TDataSourceConfig, TDbConnection, TDbSerialTransaction unit tests
TDataCharset Parsing Charset from DSN when present, reverse map dbspecific charset to PRADO charset Serial Transactions when AutoCommit is false TDbConnection commit/rollback -> implemented by TDbTransaction unit tests for charset and DbSpecific TDbDriverCapabilities unit tests
…tion to explicitly restart driver specific unit tests of TDbDriverCapabilities.
sqlite command builder update
…es for being driver specific.
…n instance. adds IScaffoldInput for custom class validation.
Conflicts: .github/workflows/prado.yml tests/unit/Data/TDbConnectionTest.php tests/unit/Data/TDbTransactionTest.php
…uring development accidentally committed this.
…fic sql. replaces mssql with SqlSvr in the doc blocks. cleaned up the driver specific charsets.
…ugh Data IDbConnection for PDO specific connections and IDataConnection for others. Updated doc blocks
Fixed a sqlite bug with charset.
2bd2e4b to
6da956c
Compare
IDbHasSchema converted to IDataHasSchema
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is the list of changes to Data:
TDbDriverclass to centralize the names of the PDO Drivers.TDataCharsetclass to normalize Data Charsets.PradoUnit - [@todo - this feature should be abstracted to be key based and allow other unit tests to not repeat multiple of the same errors]
(these are on by default. are they really so common?)
About 70% of this PR is unit tests.
Tested but removed: