Introduce GovActionsDoNotExist Logic

[yHSJ]

Closes #924.

This PR introduces logic to validate that gov actions which are being voted on actually exist at the time of voting. It is also my first use of the new GitHub stacks feature!

---

_{Stack created with GitHub Stacks CLI • Give Feedback 💬}

Summary by CodeRabbit

• Bug Fixes

  • Governance votes now reject references to nonexistent governance actions.
  • Votes recognize governance proposals created earlier in the same block.
  • Validation reports unknown voters and missing governance actions separately.

• Tests

  • Added coverage for missing actions, invalid action indexes, committee votes, and transactions mixing valid and invalid proposals.

• Documentation

  • Added a changelog entry describing the updated governance-action validation.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 56412a18-e4a9-40be-bf73-162eed9052ba

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

Walkthrough

Voting procedures now validate governance-action references against initial and same-block proposal state. Missing actions produce the GovActionsDoNotExist predicate. Four negative fixtures cover the new behavior.

Changes

Governance action validation

Layer / File(s)	Summary
Proposal state lookup crates/amaru-ledger/src/context/default/validation.rs	ProposalsSlice::exists recognizes proposals present at block start and proposals acknowledged earlier in the current block.
Voting procedure validation crates/amaru-ledger/src/rules/transaction/phase_one/voting_procedures.rs, crates/amaru-ledger/src/rules/transaction/phase_one/fixture.rs	Voting validation reports unknown proposal IDs through GovActionsDoNotExist. The phase-one fixture maps the error to the new predicate.
Validation fixtures and conformance updates crates/amaru-ledger/tests/data/phase-one/fail/GovActionsDoNotExist/*, crates/amaru-ledger/tests/data/rules-conformance.failures.toml, CHANGELOG.md	Four negative fixtures cover absent governance actions. The obsolete conformance failure entry is removed, and the changelog records the change.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant Transaction
  participant VotingProcedures
  participant ProposalsSlice
  participant Predicate
  Transaction->>VotingProcedures: execute voting procedures
  VotingProcedures->>ProposalsSlice: validate governance-action references
  ProposalsSlice-->>VotingProcedures: return missing proposal IDs
  VotingProcedures->>Predicate: map GovActionsDoNotExist
  Predicate-->>Transaction: return validation failure

Loading

Possibly related issues

• pragma-org/amaru#932 — Adds related Conway ledger predicate coverage for invalid governance-action references, but targets InvalidPrevGovActionId.

Possibly related PRs

• pragma-org/amaru#183 — Modifies proposal identification and proposal state lookup in the same validation area.
• pragma-org/amaru#199 — Extends voting-procedure validation and its test fixtures.
• pragma-org/amaru#1014 — Adds phase-one predicate handling and maps a corresponding validation error.

Suggested reviewers: ktorz, jeluard

Poem

Votes seek their proposals, neat and bright,
Same-block actions join the flight.
Missing IDs meet their proper fate,
A predicate guards the ledger gate.
Four fixtures roll in like a boss fight.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the main change: introducing GovActionsDoNotExist validation logic.
Linked Issues check	✅ Passed	The changes implement GovActionsDoNotExist validation and add the required predicate fixtures for issue #924.
Out of Scope Changes check	✅ Passed	The implementation, tests, conformance update, and changelog entry directly support the linked issue objectives.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch josh/gov-actions-do-not-exist

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}