Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
publishjob to the release workflow that publishes to npm with provenance using OIDClatest)publishConfigwithprovenance: trueandaccess: "public"to package.jsonid-token: writepermission for provenance attestationSecurity hardening
In addition to the new publish job, this PR nails down some loose ends in the existing workflow:
on: push: tags: ['10.*']instead ofon: create, which fired for both tags and branches. This also restricts to 10.x version tags only.releasejob —${{ steps.create-release.outputs.result }}was interpolated directly into ascript:block. Now passed viaRELEASE_DATAenv var and parsed withJSON.parse.releasedeclarescontents: write,publishdeclarescontents: read+id-token: write.Open question
publishjob require manual approval via a GitHub Environment (e.g.npm) with required reviewers? Currently noted as a TODO — any collaborator with write access can push a tag and trigger a publish without approval. See https://docs.github.com/en/actions/how-tos/deploy/configure-and-manage-deployments/manage-environmentsSetup required
preactjs/preactGitHub repo for provenance verification