fix: use DATETIME instead of TIMESTAMP for MySQL/TiDB tstamp column (Y2K38)#1053
Open
Yanhu007 wants to merge 1 commit intopressly:mainfrom
Open
fix: use DATETIME instead of TIMESTAMP for MySQL/TiDB tstamp column (Y2K38)#1053Yanhu007 wants to merge 1 commit intopressly:mainfrom
Yanhu007 wants to merge 1 commit intopressly:mainfrom
Conversation
MySQL TIMESTAMP type is affected by the Year 2038 problem — it stores values as a 32-bit signed integer Unix timestamp, limiting the maximum representable time to 2038-01-19 03:14:07 UTC. Change the tstamp column type to DATETIME for both MySQL and TiDB dialects. DATETIME stores the date and time as-is with a range up to 9999-12-31 23:59:59, avoiding the Y2K38 overflow. Also use CURRENT_TIMESTAMP (SQL standard) instead of now() for the default value for consistency. Note: this only affects newly created goose_db_version tables. Existing tables retain their TIMESTAMP column. Fixes pressly#432
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #432
Problem
The
goose_db_versiontable uses MySQLTIMESTAMPtype for thetstampcolumn.TIMESTAMPstores values as a 32-bit signed Unix timestamp, with a maximum of 2038-01-19 03:14:07 UTC (the Year 2038 problem).Fix
Change to
DATETIMEfor both MySQL and TiDB dialects:DATETIMEsupports dates up to 9999-12-31 23:59:59CURRENT_TIMESTAMP(SQL standard) instead ofnow()for the defaultOnly affects newly created tables. Existing tables continue to work.