Support dynamic filter for hash join - #15763
Conversation
|
|
14b080a to
d88b8aa
Compare
highker
left a comment
There was a problem hiding this comment.
Haven't looked into design yet. Maybe let's fix the coding style first?
There was a problem hiding this comment.
We don't use any abbreviations or acronyms in our code base. Please spell out bf. Also, there are a lot of other places in this PR having this issue. Could you go over them and fix accordingly?
There was a problem hiding this comment.
"bloom" is a weird name. Use "bloomfilter"
Sure, I will fix them right away. |
8950c98 to
e4f2c33
Compare
|
Gentle Ping! 🙏 |
|
@kewang1024, could you help to review this PR? |
|
Its is a great contribution. only a gentle reminder. :) |
|
Is this still being worked on? @SilenceJD |
|
@SilenceJD Hope all is well with you. Just checking in to see if you are still planning to work on this PR? |
@yingsu00 yes, I'd be happy to follow up on this PR if community can give some feedback and suggestions. |
@rohanpednekar Thank you for your concern. I can continue to work for this request, and I'm glad you and your partners can join in. |
|
Thanks @SilenceJD. @yingsu00, Do you think you can further review this PR and provide your feedback for @SilenceJD ? |
|
@SilenceJD @rohanpednekar do we have any updates on this? This would be very helpful for us and would be happy to work on this to get it out asap. |
|
We had the same problem, which cause prestodb had bad perf in tpcds q17 compare with trino |
|
@atris Ses if you can pick this one? |
|
@SilenceJD it looks like this slipped between the cracks. Nonetheless, this would be a great feature, and could significantly improve TPC-DS performance, so I'm hoping you could help us pick this back up. We would like to help you push this forward--are you prepared to address review feedback and help move it forward? If so, we can review and help. |
@tdcmeehan Thank you very much for your reply, I am glad that you can help and start this work again. But this pr is already far behind the master branch, I may need to resubmit a new pr based on the master branch and improve some of the previous implementations. Please give me some time~ |
|
@SilenceJD that's wonderful--we'll be ready to look once you've rebased and are ready for review. Thanks a lot! |
|
Is this still being working on? |
|
@sajjoseph I'm working on this, see prestodb/rfcs#54 |
Support dynamic filter for hash join. Currently, Presto 0.241+ supports local dynamic filtering for broadcast inner-joins, but does not have a dynamic filtering for hash inner-joins. This PR add a new session property "ENABLE_HASH_JOIN_DYNAMIC_FILTERING" which support dynamic filter for hash join.