[WIP] Fix code based on review comment and add CI integration#1372
Merged
lukasoppermann merged 2 commits intoMay 4, 2026
Merged
Conversation
|
Agent-Logs-Url: https://github.com/primer/primitives/sessions/c230b8f8-e545-4387-a486-326f7103e1a8 Co-authored-by: lukasoppermann <813754+lukasoppermann@users.noreply.github.com>
lukasoppermann
added
the
skip changeset
lukasoppermann
merged commit 61cef5f
into
feat/token-tooling-improvements
21 of 23 checks passed
Copilot stopped work on behalf of
lukasoppermann due to an error
May 4, 2026 08:23
lukasoppermann
added a commit
that referenced
this pull request
May 4, 2026
* chore: add token validation and extraction utilities - Add husky pre-commit hook for token validation - Add removed token detection script and lint rule - Add token name extraction utilities with tests - Refactor buildFigma to support new token tooling These utilities enable linting and validation of token removal patterns, preventing accidental deprecation of active design tokens. skip-changeset: true Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: apply Prettier formatting to color-scales.md Agent-Logs-Url: https://github.com/primer/primitives/sessions/62862b8b-5de5-4ab4-87d7-5079352e5c5b Co-authored-by: lukasoppermann <813754+lukasoppermann@users.noreply.github.com> * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * fix: return null when --base flag has no value in getArg Agent-Logs-Url: https://github.com/primer/primitives/sessions/641948a0-fd71-40b7-be44-2454938872dd Co-authored-by: lukasoppermann <813754+lukasoppermann@users.noreply.github.com> * [WIP] Fix code based on review comment and add CI integration (#1372) * Initial plan * feat: add CI integration for removed token check Agent-Logs-Url: https://github.com/primer/primitives/sessions/c230b8f8-e545-4387-a486-326f7103e1a8 Co-authored-by: lukasoppermann <813754+lukasoppermann@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: lukasoppermann <813754+lukasoppermann@users.noreply.github.com> * fix: add fetch-depth: 0 to CI checkout step to fix merge-base failure Agent-Logs-Url: https://github.com/primer/primitives/sessions/7bc74156-cbd8-4525-a3be-c99027f33c40 Co-authored-by: lukasoppermann <813754+lukasoppermann@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: lukasoppermann <813754+lukasoppermann@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
checkRemovedTokensis only in Husky pre-commit, not CIcheck:removed-tokensnpm script topackage.json.github/workflows/ci.ymlto fetch base branch and run the removed-token check on PRs