-
Notifications
You must be signed in to change notification settings - Fork 661
Replace ActionBar overflow calculations with CSS wrapping approach
#7655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
iansan5653
wants to merge
31
commits into
main
Choose a base branch
from
actionbar-css
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
f75cb4d
Replace `ActionBar` overflow calculations with CSS wrapping approach
iansan5653 dda90da
Add CSS-based menu visibility
iansan5653 8f1f205
Add changeset
iansan5653 83b23e4
Merge branch 'main' into actionbar-css
francinelucca c0060f3
Set visibility:hidden on overflowing items
iansan5653 88c6e77
Merge branch 'actionbar-css' of https://github.com/primer/react into …
iansan5653 ef6c5ec
Add comment re overflow detection
iansan5653 f3ff80f
Change to use attribute presence instead of str value
iansan5653 fe98650
Fix items being hidden due to incorrect CSS selector
iansan5653 46269af
Fix last group overflowing
iansan5653 6c839cd
Don't show menu button if no valid items registered
iansan5653 357276a
Format
iansan5653 1dfff5b
Fix snapshot test
iansan5653 9b6aeca
Update another test
iansan5653 7127891
Fix focus zone configuration
iansan5653 23e7d5f
Use CSS instead of filtering
iansan5653 81446b2
Merge branch 'main' into actionbar-css
iansan5653 4c3ff6b
chore: auto-fix lint and formatting issues
iansan5653 3206cee
Fix selecting overflow button when no items are overflowing
iansan5653 9b350c1
Merge branch 'actionbar-css' of https://github.com/primer/react into …
iansan5653 a760177
Remove ocnsole log
iansan5653 88b089b
Actually fix the issue
iansan5653 5bc40ac
Fix overflow menu anchor size
iansan5653 c486d19
Fix focus issue
iansan5653 d533eb5
Remove text labels story
iansan5653 c06312d
Fix small size alignment issues
iansan5653 019bd12
Fix bug with returning focus to an overflowed item
iansan5653 73c6db3
Make focus zone strict: true
iansan5653 3811f44
Use `focusableElementFilter` with `overflowItems` as a dependency
iansan5653 ad6ddff
Merge branch 'main' into actionbar-css
iansan5653 30ea75a
Merge branch 'main' into actionbar-css
francinelucca File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@primer/react": minor | ||
| --- | ||
|
|
||
| Replace `ActionBar` overflow calculations with CSS wrapping approach to improve performance and stability |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.