fix: use frederick lean repl + gc#11
Merged
Merged
Conversation
Contributor
|
tracking memory usage for the repl can be quite subtle since there is a parent lake process and some lean process under it. And the parent lake process doesnt consume that much memory. Here is how to benchmark memory usage properly leanprover-community/repl#77 (comment) |
desaxce
commented
Jun 13, 2025
| infotree_type = body.infotree_type | ||
| disable_cache = body.disable_cache | ||
|
|
||
| minibatches = split_into_minibatches(codes, 5) |
Contributor
Author
There was a problem hiding this comment.
We have codes be an array with single element today.
The reason why codes was added is to avoid having to many network requests due to firewall restrictions.
Do the mini-batches help if len(codes) = 1 in benchmarks?
Contributor
There was a problem hiding this comment.
mini-batches only work if you are being passed a large batch consisting of multiple codes.
desaxce
force-pushed
the
hugues/take-frederick-repl
branch
from
8501f5d to
edc3c59
Compare
Contributor
Author
|
I moved your latest commit to #15. |
desaxce
changed the title
* fix: Infinite loop * Compress mathlib header
…nto hugues/take-frederick-repl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrate Frederick Lean repl changes from https://github.com/FrederickPu/repl/tree/lean415compat